fix(a11y): add skip link, landmark labels, and sidebar navigation for screen readers#10390
Open
bmatar wants to merge 1 commit intoshadcn-ui:mainfrom
Open
fix(a11y): add skip link, landmark labels, and sidebar navigation for screen readers#10390bmatar wants to merge 1 commit intoshadcn-ui:mainfrom
bmatar wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
… screen readers Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
@bmatar is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs site scores 100 on Lighthouse accessibility and has solid semantic HTML throughout. These changes add landmark labels and a skip link to further improve navigation for screen reader and keyboard-only users.
Issues identified using Tactual, a screen-reader navigation cost analyzer:
<div>.<header>,<footer>, and<nav>have noaria-label, making them indistinguishable when navigating by landmark.Changes (zero visual impact except skip link on Tab focus)
skip-to-content.tsx(new)layout.tsxid="content"on<main>sidebar.tsx<div>→<nav aria-label="Docs sidebar">for non-collapsible sidebarmain-nav.tsxaria-label="Main"on<nav>site-header.tsxaria-label="Site header"on<header>site-footer.tsxaria-label="Site footer"on<footer>Note: the
sidebar.tsxchange is in the registry — it improves the distributed Sidebar component for projects usingcollapsible="none".Verification
🤖 AI-assisted (Claude). All changes manually verified with NVDA.